Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix/use u qm to reshape graphs #7

Merged
merged 6 commits into from
Mar 16, 2024
Merged

Conversation

kntkb
Copy link
Collaborator

@kntkb kntkb commented Mar 16, 2024

Description

This PR fixes #6 and #8

Todos

Notable points that this PR has either accomplished or will accomplish.

Questions

Status

  • Ready to go

@kntkb kntkb marked this pull request as ready for review March 16, 2024 23:16
@kntkb
Copy link
Collaborator Author

kntkb commented Mar 16, 2024

Unexpected error from espfit/tests/test_app_train_sampler.py

RuntimeError: Trying to backward through the graph a second time (or directly access saved tensors after they have >already been freed). Saved intermediate values of the graph are freed when you call .backward() or autograd.grad(). >Specify retain_graph=True if you need to backward through the graph a second time or if you need to access saved >tensors after calling backward.

This is not critical for current experiment purpose so force merge. Above error will be resolved in the upcoming PR.

@kntkb kntkb merged commit 0cd025f into main Mar 16, 2024
1 check failed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
1 participant